search

vincepii / konsole-multi-terminal

Different terminal split implementation for Konsole (multi terminal)
Other
11 stars 2 forks source link

Removing old split view breaks yakuake #12

Closed vincepii closed 10 years ago

vincepii commented 10 years ago

This is not acceptable:

$ yakuake
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.
Object::connect: No such signal Konsole::ViewManager::splitViewToggle(bool)
yakuake: symbol lookup error: /usr/lib/kde4/libkonsolepart.so: undefined symbol: _ZN7Konsole11ViewManager19setNavigationMethodENS0_16NavigationMethodE
unnamed app(3897): Communication problem with  "yakuake" , it probably crashed. 
Error message was:  "org.freedesktop.DBus.Error.NoReply" : " "Message did not receive a reply (timeout by message bus)" "
vincepii commented 10 years ago

Reintroduced code for old split views functionality.

mjobin-mdsol commented 10 years ago

you should probably create PR instead of issues and only saying you've fixed it ... issues dont have code attached.

yakuake could probably be modified to support new code base... anyway, good luck

vincepii commented 10 years ago

I opened the issue as such, then I decided to quickly fix it and close it. I will use PRs, thanks for the suggestion :)!