search

vincjo / datatables

A toolkit for creating datatable components with Svelte
https://vincjo.fr/datatables
MIT License
475 stars 18 forks source link

Fix breaking rune change in svelte 5 (frozen => raw) #121

Closed icheered closed 3 months ago

icheered commented 3 months ago

https://github.com/sveltejs/svelte/pull/12808 breaks this application, I created a PR to fix this issue: https://github.com/vincjo/datatables/pull/120.

Without fixing, the application breaks at startup with the following errors:

✘ [ERROR] node_modules/@vincjo/datatables/dist/src/client/AbstractTableHandler.svelte.js:7:14 `$state.frozen` is now `$state.raw` [plugin vite-plugin-svelte:optimize-svelte]

    node_modules/@vincjo/datatables/dist/src/client/AbstractTableHandler.svelte.js:7:14:
      7 │    rawRows = $state.frozen([]);
        ╵               ^

  The plugin "vite-plugin-svelte:optimize-svelte" was triggered by this import

    node_modules/@vincjo/datatables/dist/src/client/TableHandler.svelte.js:4:33:
      4 │ import AbstractTableHandler from './AbstractTableHandler.svelte';
        ╵                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] node_modules/@vincjo/datatables/dist/src/client/helpers/RecordFilterHelper.svelte.js:5:17 `$state.frozen` is now `$state.raw` [plugin vite-plugin-svelte:optimize-svelte]

    node_modules/@vincjo/datatables/dist/src/client/helpers/RecordFilterHelper.svelte.js:5:17:
      5 │    rawRecords = $state.frozen([]);
        ╵                  ^

  The plugin "vite-plugin-svelte:optimize-svelte" was triggered by this import

    node_modules/@vincjo/datatables/dist/src/client/TableHandler.svelte.js:17:31:
      17 │ import RecordFilterHelper from './helpers/RecordFilterHelper.svelte';
icheered commented 3 months ago

Closed in https://github.com/vincjo/datatables/pull/120