Pagination example is broken

vincjo / datatables

A toolkit for creating datatable components with Svelte

https://vincjo.fr/datatables

MIT License

475 stars 18 forks source link

Pagination example is broken #127

Closed Beramos closed 2 months ago

Beramos commented 2 months ago

Hi thanks for this awesome library! I noticed the result displayed at https://vincjo.fr/datatables/tutorial/pagination throws an error:

Uncaught (in promise) TypeError: l.getCurrentPage is not a function
    Immutable 40
    <anonymous> https://vincjo.fr/datatables/tutorial/pagination:124
    promise callback* https://vincjo.fr/datatables/tutorial/pagination:123

browser:

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0

vincjo commented 2 months ago

Hi, thanks a lot for letting me know. This was actually an error in the naming of a method:

- const currentPage = handler.getCurrentPage()
+ const pageNumber = handler.getPageNumber()

Just fixed it 👍

Beramos commented 2 months ago

Awesome!

On Mon, 16 Sep 2024, 15:43 vincjo, @.***> wrote:

Hi, thanks a lot for letting me know. This was actually an error in the naming of a method:

const currentPage = handler.getCurrentPage()+ const pageNumber = handler.getPageNumber()

Just fixed it 👍

— Reply to this email directly, view it on GitHub https://github.com/vincjo/datatables/issues/127#issuecomment-2352963579, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYUUXDLI7ZWWM7IV4JKTOTZW3N7JAVCNFSM6AAAAABOHUWNVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSHE3DGNJXHE . You are receiving this because you authored the thread.Message ID: @.***>