Closed kilianmh closed 1 year ago
Looks good to me, thanks again.
We probably don't need a call to cl-ppcre in the non-regex cases (I know I wrote them, it was handy for the replace-all) (and although I would take care to not slow down the functions, so this isn't for this PR).
Yeah I also thought that for now only implement regex
and then we see later if non-regex replace functions can be implemented with standard cl functions.
Add
regex
keyword parameter toreplace-first
,replace-all
,replace-using
. Also update docstrings, README, and add test-cases.closes #63