vindarel / cl-str

Modern, simple and consistent Common Lisp string manipulation library.
https://vindarel.github.io/cl-str/
MIT License
305 stars 37 forks source link

Feat: regex support for replace functions #106

Closed kilianmh closed 1 year ago

kilianmh commented 1 year ago

Add regex keyword parameter to replace-first, replace-all, replace-using. Also update docstrings, README, and add test-cases.

closes #63

vindarel commented 1 year ago

Looks good to me, thanks again.

We probably don't need a call to cl-ppcre in the non-regex cases (I know I wrote them, it was handy for the replace-all) (and although I would take care to not slow down the functions, so this isn't for this PR).

kilianmh commented 1 year ago

Yeah I also thought that for now only implement regex and then we see later if non-regex replace functions can be implemented with standard cl functions.