Add regex to split function family

vindarel / cl-str

Modern, simple and consistent Common Lisp string manipulation library.

https://vindarel.github.io/cl-str/

MIT License

305 stars 37 forks source link

Closed ccqpein closed 9 months ago

ccqpein commented 9 months ago

Add regex keyword to split rsplit and split-omit-nulls. Update README and tests

Relates: Issue PR

kilianmh commented 9 months ago

Thank you for your first PR @ccqpein !

LGTM, also that you updated the tests and Readme.

One thing you could add is

If regex keyword is not nil, separator is treated as regular expression.

also to the docstrings of rsplit and split-omit-nulls.

ccqpein commented 9 months ago

@kilianmh I just added, please check it out.