search

vindarel / cl-str

Modern, simple and consistent Common Lisp string manipulation library.
https://vindarel.github.io/cl-str/
MIT License
305 stars 37 forks source link

feat: account for Japanese whitespace #120

Closed fosskers closed 2 months ago

fosskers commented 2 months ago

Japanese whitespace... the silent killer.

kilianmh commented 2 months ago

After the disaster last year, we should test on all implementations before adding characters. For me loading works with sbcl, ccl, ecl, cmu, and clisp. On abcl during loading str we get:

Unrecognized character name: "Ideographic_space"
   [Condition of type ERROR]

I guess we have to work with the character-code on abcl at least and maybe also other implementations.

fosskers commented 2 months ago

I will test on Clasp.

Tests pass on Clasp.

kilianmh commented 2 months ago

Abcl now works! +1 So remaining are at least GCL, lispworks and allegro.

kilianmh commented 2 months ago

Maybe @CK-DE you can check with lispworks?

kilianmh commented 2 months ago

allegro 11 works as well for me

fosskers commented 2 months ago

I'd test on GCL but I can't for the life of me get it to compile.

kilianmh commented 2 months ago

I just tested and both lispworks and gcl both error on #\Ideographic_space so should also use only the char-code. After that it should be ready to merge ;)

fosskers commented 2 months ago

Ah nice, those are two I can't test. I'll add the feature for those two tomorrow morning.

kilianmh commented 2 months ago

Thank you @fosskers for improving this library!