Closed kilianmh closed 1 year ago
I was seeing an interest in calling the built-in concatenate
, mainly to show the use of built-ins to new readers. Then it might be slightly more efficient, and more future-proof against a silly str:concat
change. The other changes are good stylistic practice, this one less sure. What do you think?
show the use of built-ins to new readers
Does the function definition of str:concat
not already show the use of concatenate to new readers of cl-str
? ;)
slightly more efficient, and more future-proof against a silly
str:concat
change
In that case the users should quickly find out about concatenate
in the hyperspec. Alternatively we could mention concatenate
in a comment / docstring.
So then you want me to revert concat
to concatenate
for now so the other changes can be merged?
So then you want me to revert
concat
toconcatenate
for now so the other changes can be merged?
yes please :)
Now it should be as discussed ;)
Thank you again!
concatenate
withconcat
if
with singlecond
unless null
withwhen
if
without else clause withwhen