search

vindolin / ninepatch

Slice Android style 9-patch images, resize and interactively preview them.
MIT License
20 stars 6 forks source link

added convenience render methods #3

Closed nlaurance closed 9 years ago

nlaurance commented 9 years ago

I successfully injected generated images containing text in the "bubbles" It made sense to factor out some convenience methods to achieve this in one line.

vindolin commented 9 years ago

Hi Nicolas, and thanks for the patch! It looks like you're using reST fields for the function parameters/return values, but the rest of the library does not, I'll look if I find the time to add them next weekend. It would make sense to add some command line support for the "fit" (dimensions) and "wrap" (different name for render_with_content, parameter: PNG-image, to wrap around the 9patch) features before integrating it, would you mind adding them to bin/ninepatch?

Cheers!

nlaurance commented 9 years ago

hello Thomas,

would you like to rename the methods to fit and wrap (resp.) ? I'll see for the command line, but that is far from my use case. You can see what I did with it here : http://python-thoughts.blogspot.ie/2015/05/tdd-test-driven-documentation.html

On Sun, May 10, 2015 at 6:46 PM, Thomas Schüßler notifications@github.com wrote:

Hi Nicolas, and thanks for the patch! It looks like you're using reST fields for the function parameters/return values, but the rest of the library does not, I'll look if I find the time to add them next weekend. It would make sense to add some command line support for the "fit" (dimensions) and "wrap" (different name for render_with_content, parameter: PNG-image to wrap around the 9patch) features before integrating it, would you mind adding them to bin/ninepatch?

Cheers!

— Reply to this email directly or view it on GitHub https://github.com/vindolin/ninepatch/pull/3#issuecomment-100674284.

Nicolas Laurance

nlaurance commented 9 years ago

command line fit and wrap are now implemented