vineetasharma / peoplePlugin

people plugin
MIT License
0 stars 0 forks source link

Not using image resize function. #28

Closed ianblair44 closed 8 years ago

ianblair44 commented 8 years ago

https://github.com/BuildFire/sdk/wiki/How-to-use-ImageLib

Scroll to the bottom of the page and make sure we use this to ensure we are always getting the fastest load times.

sakshityagi commented 8 years ago

Hey Ian, in issue https://github.com/deepakshrma/peoplePlugin/issues/24 we have to force the image dimension using css and show cropped image. I have done it using css and buildfire.imageLib.cropImage() and it is working fine. I don't understand where do I need to use resize() method?

sakshityagi commented 8 years ago

Done. please review. Now small images are being loaded in case of thumbnails. Also fixed carousel images image dimension issue.