Added a function and a test for the python flash finder. The script is a copy of the code we got, with minimal changes to make it into a function (and make it work with python 3.x).
I recommend we dump all python files we incorporate in the code initially in the wbi.legacy module, and slowly extract the functionality out of it to a cleaned-up standard wbi module.
Some things to note:
I've added the minimal data to run python flash finder in the test_data folder. This is identical to the data we got, except that the sCMOS_Frames_U16_1024x512.dat has just 90 frames to make it manageable (and within 100MB github limit).
There are at least 2 bugs in flash_finder.py, which have their own test cases. Once these bugs are removed, the test cases can be modified as well.
Right now this is just a script, not a wbi command. We can convert it to a command at some point.
There are a few TODO comments that I added to flash_finder.py. These should be fixed when we make this a wbi command.
Added a function and a test for the python flash finder. The script is a copy of the code we got, with minimal changes to make it into a function (and make it work with python 3.x).
I recommend we dump all python files we incorporate in the code initially in the
wbi.legacymodule, and slowly extract the functionality out of it to a cleaned-up standardwbimodule.Some things to note:
test_datafolder. This is identical to the data we got, except that thesCMOS_Frames_U16_1024x512.dathas just 90 frames to make it manageable (and within 100MB github limit).flash_finder.py, which have their own test cases. Once these bugs are removed, the test cases can be modified as well.wbicommand. We can convert it to a command at some point.TODOcomments that I added toflash_finder.py. These should be fixed when we make this awbicommand.