search

vineetjc / pygame-Coin-Fall-

Collect as many coins from the coin fall in 30 seconds. Avoid the bombs! Made using pygame.
MIT License
6 stars 15 forks source link

highscore added[not encrypted] #28

Closed AbhinandanKainth closed 5 years ago

AbhinandanKainth commented 5 years ago

it shows the high score, but it is saved in a txt file in an unencrypted manner. i have also added some backgrounds suggestions in images/NewBackgrounds

AbhinandanKainth commented 5 years ago

it shows the high score, but it is saved in a txt file in an unencrypted manner. i have also added some backgrounds suggestions in images/NewBackgrounds

AbhinandanKainth commented 5 years ago

but the user won't be staying on the game over screen for long, so it won't cause much performance issue.

amrit-choudhary commented 5 years ago

Right now it’s fast but what happens when you add encryption, then every read and write will take more time. Also, later when we add online highscore, we can’t call the server 60 times a second.

vineetjc commented 5 years ago

@kainthcool Resolve conflicts please

AbhinandanKainth commented 5 years ago

How to remove them? I am new to all these, can you please guide me a bit.

vineetjc commented 5 years ago

@kainthcool just make sure you're updated with the latest version of the repo and then make your changes again and update this PR

AbhinandanKainth commented 5 years ago

i have resolved conflicts ,please review it

vineetjc commented 5 years ago

@kainthcool it's good for now, I merged it, well done!