vinegarhq / vinegar

An open-source, minimal, configurable, fast bootstrapper for running Roblox on Linux.
https://vinegarhq.org
GNU General Public License v3.0
375 stars 34 forks source link

Roblox's process still alive after closing the window #387

Closed splatert closed 4 months ago

splatert commented 4 months ago

Acknowledgement of preliminary instructions

What problem did you encounter?

Closing Roblox does not end its process. You can find it on the process list still running. In order to visit different places, I have to keep closing any running instances.

Steps to reproduce this issue:

  1. Join a place
  2. Leave it
  3. Find Roblox still running in process list / task manager.

System information

* Vinegar: v1.7.3 
* Distro: Freedesktop SDK 23.08 (Flatpak runtime)
* Processor: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
  * Supports AVX: true
  * Supports split lock detection: false
* Kernel: 5.15.0-87-generic
* Wine (Player): v9.2 (Staging)*
* Wine (Studio): v9.2 (Staging)*
* Flatpak: [x]
* Cards:
  * Card 0: nvidia 0000:01:00.0 /sys/class/drm/card0
EDLLT commented 4 months ago

Acknowledgement of preliminary instructions

* [x]  I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?

Closing Roblox does not end its process. You can find it on the process list still running. In order to visit different places, I have to keep closing any running instances.

Steps to reproduce this issue:

1. Join a place

2. Leave it

3. Find Roblox still running in process list / task manager.

System information

* Vinegar: v1.7.3 
* Distro: Freedesktop SDK 23.08 (Flatpak runtime)
* Processor: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
  * Supports AVX: true
  * Supports split lock detection: false
* Kernel: 5.15.0-87-generic
* Wine (Player): v9.2 (Staging)*
* Wine (Studio): v9.2 (Staging)*
* Flatpak: [x]
* Cards:
  * Card 0: nvidia 0000:01:00.0 /sys/class/drm/card0
* Sysinfo mentions that I'm on Wine 9.2 Staging but I'm in fact using Wine GE.

Faced the same issue back when I using flatpak A source installation fixed the issue for me (also allowed me to run multiple instances of roblox which the flatpak version isn't capable of)

Coder2195Text commented 4 months ago

Interesting. I faced the same issue on source and got it fixed via flatpak.

wisheth commented 4 months ago

This is an issue that has persisted with me for a while. I use Flatpak

EDLLT commented 4 months ago

Interesting. I faced the same issue on source and got it fixed via flatpak.

Interesting When you were using a source installation, which wine prefix did you set?

Because in my case a source installation fixed the issue, I had my wine set to wine ge initially but after wael compiled vinegar's wine, I began using that instead and it fixed all of my issues(talking about the source installation here)

Coder2195Text commented 4 months ago

Turns out flatpak is also screwing up again, so it's both platforms. When I was on source, I just went into flatpak files and copied their binaries for wine stuff.

On Sat, Feb 24, 2024 at 5:48 PM EDllT @.***> wrote:

Interesting. I faced the same issue on source and got it fixed via flatpak.

Interesting When you were using a source installation, which wine prefix did you set?

Because in my case a source installation fixed the issue, I had my wine set to wine ge initially but after wael compiled vinegar's wine, I began using that instead and it fixed all of my issues(talking about the source installation here)

— Reply to this email directly, view it on GitHub https://github.com/vinegarhq/vinegar/issues/387#issuecomment-1962749839, or unsubscribe https://github.com/notifications/unsubscribe-auth/APBF2O7NPIJPGNTDYKFPDYDYVJU2NAVCNFSM6AAAAABDV64CAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSG42DSOBTHE . You are receiving this because you commented.Message ID: @.***>

apprehensions commented 4 months ago

Roblox logs?

apprehensions commented 4 months ago

Fixed in ee9ef615b92888955ecdcfb569cc45e03df24637