search

vinenoobjelly / jellyfishlights-py

12 stars 5 forks source link

Allow reconnections and multiple controller instances #3

Closed bdunn44 closed 1 year ago

bdunn44 commented 1 year ago

Two small but important fixes:

  1. Remove class attributes in favor of instance attributes. This allows each instance of the controller class to have their own websocket object, for example, instead of sharing one (which can lead to read conflicts)
  2. Recreate the websocket object after disconnect to allow reconnections (websockets that have been disconnected can/should not be reused)
vinenoob commented 1 year ago

This looks pretty good. I'm just waiting for when I have time to both approve it and do a release

bdunn44 commented 1 year ago

Closing in favor of #5