search

vineodd / PIMSim

PIMSim is a Process-In-Memory Simulator with the compatibility of GEM5 full-system simulation.
GNU General Public License v3.0
178 stars 85 forks source link

Found bug in gem5/src/mem/abstract_mem.cc #19

Open anaarduengo opened 4 years ago

anaarduengo commented 4 years ago

I have not been able to run the simulator, but I was having a look at the code and I saw the following in line 458 of the file gem5/src/mem/abstract_mem.cc

for(auto i=pendingPIMqueue.begin();i!=pendingPIMqueue.end();i++){
    if((*i)->addr[0]==senderState->addr[0]&&(*i)->addr[0]==senderState->addr[0]&&(*i)->addr[0]==senderState->addr[0]){
        found=true;
        index=i;
        threadid=(*i)->threadid;
        break;

    }
 }

The condition of the if repeats three times, I think it should be checking that the positions 0, 1 and 2 of the addr vector are the same as the ones of the addr vector in the SenderState.

NabiiBux commented 3 years ago

Tell me which software you are using for the simulation of gem5 and pim simulation Help me