Closed a-schild closed 5 years ago
That's great! It says in the README: "TODO: In one of the upcoming alpha versions, methods will return model objects and not plain arrays."
So I was initially planning to do this, but I haven't yet got the time to do it. Feel free to submit your changes with backwards incompatibility, since this project is still in alpha state anyway. I don't see the use case of separate calls, that would probably just be confusing and working with domain objects is much nicer.
People who need the array data can peg their version constraint to ~0.3.0
easily.
I would just ask you that your code be PSR-2 compliant. 🙂
@YetiCGN Currently you define php 7.0.9+ as required PHP version. Can I bump this to 7.1+, so we can define nullable arguments + void return types? One problem with php 7.1+ might be, that all debian 9x version only ship with php 7.0x and you have to add other package sources for php 7.1, 7.2 7.3 support.
PS: PSR-2 on focus ;)
Yes, you can do this. Actually I came across this yesterday as well and thought "if we ever want nullable types, we need to raise this to 7.1 at least". 😆
7.0 is no longer supported, so it's safe to drop support for it if that means we can have better code because of correct strict typing. Users of Debian Stretch should switch to Ubuntu or install the ~PPA~ DPA. 😉
See #5 for a pull request. Most things work, but not yet widely tested
Merged, thanks a lot!
Hello,
I have written some classes to be used with the API, which encapsulate the calendar, events and parts of the bookings stuff of ct.
Before I make a pull request, how should I integrate it with the existing API?
Currently it would be the getCalendarEvents which I have implemented with an object model, and also the calendar part of the masterdata.