vinfamy / LifePlay

Free, Open-Source and Moddable Lifesim RPG (Link NSFW). I had to change my dev PC and couldn't set up Git correctly on the new PC so the full source code for the game will be available here: https://mega.nz/folder/1XYSXbRb#nFHZ1wdwTbL6rS1oUdMe0g
https://mega.nz/folder/1XYSXbRb#nFHZ1wdwTbL6rS1oUdMe0g
GNU Affero General Public License v3.0
70 stars 34 forks source link

Calling SexNoAffair(Player, Actor) where Actor is invalid will crash the game #208

Closed Rizean closed 2 years ago

Rizean commented 2 years ago

Calling SexNoAffair(Player, Actor) where Actor is invalid will crash the game. Haven't tested Sex(...) but would assume the same.

See LifePlay/Content/Modules/vin_NonConsensual/Scenes/ag_spiked_rape.lpscene on line 123 the Actor is not valid when the scene is forced triggered.

Could you make SexNoAffair/Sex print a message when one of the actors is invalid? ie Something to the effect of "Please report called SexNoAffair/Sex with an invalid actor."?

vinfamy commented 2 years ago

noted

vinfamy commented 2 years ago

added isValid() checks, now in the worst case scenario, it will remove invalid actors and trigger a sex scene with the remaining valid actors, SexNoAffair(Player, Actor) will turn into a solo scene if Actor is invalid