search

vingorius / jade-beautify

Jade beautify package for Atom Editor.
MIT License
7 stars 2 forks source link

Doesn't work with window:save-all #4

Closed jerone closed 8 years ago

jerone commented 8 years ago

When editing multiple documents and then pressing Save All (command window:save-all) this package doesn't seems to execute, while normal Save (command core:save) does work.

vingorius commented 8 years ago

sorry for late, i'll check.

vingorius commented 8 years ago

To: @jerone

When save-all, do i check a jade-file changed or not? Even when a jade file is not changed, do i beautify it?

jerone commented 8 years ago

Good question! I wouldn't mind if you save unchanged files, but I know other people who use filewatchers for for example Grunt might have issues with that. I would check how atom-beautify does it.

vingorius commented 8 years ago

How about give new config option "Beautify on save-all", Even the jade file is not modified, I is enforced to beautify. Waiting your opinion.

vingorius commented 8 years ago

@jerone Any update?

jerone commented 8 years ago

@vingorius Sorry must have missed your reply.

Apparently people don't like it when non-modified files are saved.

I would just implement the save-all feature (for modified files only), because when I save it I expect it to be beautified and compiled too. Maybe adding a default enabled option would help others.

Does this help you?