vinhne / cropzoom

Automatically exported from code.google.com/p/cropzoom
0 stars 0 forks source link

IE10 preview release - not working in iframe - temp hack provided #21

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
IE 10.0.9200.16438 released on 13 November 2012

My cropzoom is in an iframe. I modified jquery.cropzoom.js r62 so that it runs 
fine in IE8, IE9. However, IE10 threw an error - "NoModificationAllowedError" 
on line 196
$image.outerHTML = $image.outerHTML;

see https://github.com/jquery/jquery/pull/870
also see 
https://github.com/appendto/jquery/commit/039222f8bf4591807e5d25e2a2308a79f87e65
6d

If I understand correctly, parentNode of $image is the iframe and IE10 doen't 
allow modification if parentNode is a Document(ie. .outerHTML not allowed to be 
applied) as specified in line 180 and 182 that $image = 
document.createElement('img'); 
or 
$image = document.createElement('v:image');

For IE10, I modified with a hack
if ( $image.parentNode ) {
  $image.outerHTML = $image.outerHTML;
}
and it worked in IE8, IE9, IE10 preview release, Chrome 23.0.1271.64, Firefox 
16.0.2, Firefox 3.6

I am not sure if this can help someone as my jquery.cropzoom.js is somewhat 
customized and modified (no rotate, no zoom - I just need the crop selector to 
be movable and be able to crop) so no guarantee this will help you if you have 
a similar bug. At the very least you can refer to my links above and hopefully 
find a solution for yourself. 

Cheers.

Original issue reported on code.google.com by limeswea...@gmail.com on 16 Nov 2012 at 2:33

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Fixed in https://github.com/cropzoom/cropzoom

Original comment by forpdfse...@gmail.com on 13 May 2013 at 3:06