vini-guerrero / godot_game_tools

This is a blender add-on that contains tools to ease the creation/import process of assets into Godot Game Engine
GNU General Public License v2.0
365 stars 35 forks source link

Bonenames #1

Closed janne-ha closed 4 years ago

janne-ha commented 4 years ago

Hey!

Mixamo's ready characters come with bones named like 'Alyssa:Hips'. This PR fixes renaming those bones, as I suspect that some users might want to use those ready made models from mixamo. (at least i did)

Also to my testing it seemed that renaming the fcurves is totally needles as they seem to be changed when you rename bones. There might be a side effect that im not aware about, but I haven't ran into problems yet with my version.

About me and my intentions:

I've been learning Blender addon creation since seeing @chrisphyffer videos on the subject. I'm just starting out learning Blender API, but I think i'm getting the hang of it.. My repo There's not much yet going on it so I was thinking I should collaborate to your project. There's not all the things that i've tried with the addon as I started rewriting the whole thing.

I'm total noob on github other than making my own projects (made a new account while ago) So you should be wary of my doings ;)

You can contact me janne.ha@mail.com or Hoonius#8782 on Discord if you like :)

janne-ha commented 4 years ago

Little issue: Seems that now you need to click 'Rename Rig Bones' before 'Prepare Mixamo Rig'. Tried to get rid of the files coming from .idea folder and fixing a silly copy-paste error. Cant get GitHub to agree with me and haven't got time to try fixing it now... Just check it out and please be patient with my 'un'skills :)

Edit: I'll close this and wait for to hear from you.