search

vini-guerrero / godot_game_tools

This is a blender add-on that contains tools to ease the creation/import process of assets into Godot Game Engine
GNU General Public License v2.0
364 stars 34 forks source link

bugFix: Pose position not in rest position #33

Closed alan-w-255 closed 3 years ago

alan-w-255 commented 3 years ago

while initializing character, there is an offset between rest position and object pose position.

vini-guerrero commented 3 years ago

Hello @alan-w-255 thank you for the commit. Have you been able to test this with at least 2 mixamo characters with different armatures? The regex match is a good catch. But it's important to confirm the fcurves scales are good, the reason why it applies scales, rotation and scales is because most of the imported characters from there, armatures comes with issues that breaks when joining animations with it.

alan-w-255 commented 3 years ago

Yes, i have test 2 mixamo character, and each character has three actions. fcurve scaling to 0.01 works well. Joining animations scale every action's hip bone location fcurve to 0.01, but the code not get the hip bone because some mixamo characters hip bone names are not the same. Yes, i agree with that it should apply transform. if not apply transform , the charater's root motion is 100x in my test. The position offset is caused by location fcurves scale. It 100x the offset between rest pose and action pose.