viniciusgerevini / godot-aseprite-wizard

Godot Editor plugin to help import Aseprite animations to AnimationPlayers, AnimatedSprites and SpriteFrames.
MIT License
893 stars 43 forks source link

fix window size issue #22

Closed viniciusgerevini closed 3 years ago

viniciusgerevini commented 3 years ago

Change WindowDialog to PopupPanel to fix window size issue as reported in #15 and #19 .

Unfortunately, when changing to PopupPanel, the window title is lost. However, I don't feel this is a big of a deal. Before fix:

nofixaw

Fix:

Screen Shot 2021-04-20 at 8 58 22 pm
viniciusgerevini commented 3 years ago

Not sure if I like this solution. As no one else reported same problem I will wait until a next release comes, to see if it is fixed.

conradhappeliv commented 3 years ago

Hi! Just wanted to note that I ran into this same issue (window improperly sized, leaving the configuration button unusable, so I can't set my asperite executable path) and it's preventing me from using this plugin :(

viniciusgerevini commented 3 years ago

Thanks for letting me know @conradhappeliv . Which operational system do you use? I'll look into this again. As a workaround for now, you can use TAB and ENTER to navigate the buttons, so you can change the path. I believe you are also able to resize the screen. This may help.

conradhappeliv commented 3 years ago

That did the trick - thanks for the tip!

I'm on Windows 10. I see the issue on both computers I've tried it on, with the monitors I'm using being 1440p and 4K (laptop, so highly scaled).

viniciusgerevini commented 3 years ago

Interesting. Thanks for the extra info. That does make sense. I saw the issue happening in a retina display, with probably higher DPI than my normal monitors. I knew it was a scaling issue, but at least now I have a pattern. Cheers

justdaft commented 3 years ago

Hi I have the same problem on my Macbook pro retina screeen.

viniciusgerevini commented 3 years ago

Thanks @justdaft . Good to know. I'm fixing this issue on #25 by moving the wizard screen to the dock. I reopened the old issue #15 until the new version is released in the asset library. Cheers

justdaft commented 3 years ago

Thanks, I am also struggling to get the plug in to work, I can't seem to get the path to aseprite correctly configured, I am on a mac, do you have any suggestions?

Billy

On Thu, 10 Jun 2021 at 13:36, Vinicius Gerevini @.***> wrote:

Thanks @justdaft https://github.com/justdaft . Good to know. I'm fixing this issue on #25 https://github.com/viniciusgerevini/godot-aseprite-wizard/pull/25 by moving the wizard screen to the dock. I reopened the old issue #15 https://github.com/viniciusgerevini/godot-aseprite-wizard/issues/15 until the new version is released in the asset library. Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/viniciusgerevini/godot-aseprite-wizard/pull/22#issuecomment-858583404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALQ4B2XXSHHEPCAMJWOSKDTSCWTFANCNFSM43H56G3Q .

viniciusgerevini commented 3 years ago

Hi Billy. Try /Applications/Aseprite.app/Contents/MacOS/aseprite. This seems to be the default PATH on MacOS. You can test it by running it on the terminal.

justdaft commented 3 years ago

Fantastic, that works, and your latest version of the addon works perfectly, no more dialog box issues.

Many thanks

On Fri, 11 Jun 2021 at 05:40, Vinicius Gerevini @.***> wrote:

Hi Billy. Try /Applications/Aseprite.app/Contents/MacOS/aseprite. This seems to be the default PATH on MacOS. You can test it by running it on the terminal.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/viniciusgerevini/godot-aseprite-wizard/pull/22#issuecomment-859259249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALQ4BZIOYR3BN3VXJZQA23TSGHUXANCNFSM43H56G3Q .

viniciusgerevini commented 3 years ago

Awesome. Thank you