search

viniciusgerevini / godot-aseprite-wizard

Godot Editor plugin to help import Aseprite animations to AnimationPlayers, AnimatedSprites and SpriteFrames.
MIT License
891 stars 42 forks source link

Add config for inner padding #45

Closed HanKruiger closed 2 years ago

HanKruiger commented 2 years ago

Hi there,

Thanks for building this wizard! I was experiencing some tearing in my sprites after having importing them with this plugin, and was able to fix it by using Aseprite's inner padding option. This makes sure there's a little space between the individual sprites so that the texture is allowed to sample from outside its defined area a bit. (Because apparently that happens!)

I added it to the wizard because it may help others.

Cheers!

viniciusgerevini commented 2 years ago

Thanks for taking the time to put this contribution together @HanKruiger.

In this issue, do you see parts of other frames in the current one or it is just the node boundaries that are offset?

I've seen this happening when the filter flag is on for the texture, but I guess that's not your issue, as this would mean your sprite would be blurry.

Which Godot and Aseprite version are you using? I want to try to replicate the issue here to see if it also affects the newly added AnimationPlayer support.

Thanks

HanKruiger commented 2 years ago

In this issue, do you see parts of other frames in the current one or it is just the node boundaries that are offset?

I'm not sure what you mean with the offset node boundaries. But what I think I see is a small line that is part of another frame in the same animation. It is easiest to observe when the background contrasts with the texture by a lot.

I used an animation with dimensions 10 by 27 px. I indeed import them with filtering turned off, because it's pixel art.

I use Aseprite 1.2.32 and Godot 3.4.2.stable on macOS.

It seems like you merged a rewrite in the meantime 🙃 I'll see if the issue is there on the current version of master and let you know! I've been wanting to switch to AnimationPlayer, so thanks for taking the time to add it.

HanKruiger commented 2 years ago

Update: I changed my setup to use AnimationPlayer, and unfortunately I still see the texture tearing issue there.

I'll see if I can add the inner padding configuration to the new import mechanism.

HanKruiger commented 2 years ago

Closing this as it is replaced by #46