search

viniciusgerevini / godot-aseprite-wizard

Godot Editor plugin to help import Aseprite animations to AnimationPlayers, AnimatedSprites and SpriteFrames.
MIT License
891 stars 42 forks source link

Godot 4 Support #51

Closed floriandotorg closed 2 years ago

floriandotorg commented 2 years ago

Hey @viniciusgerevini, thanks for your awesome work! I took the liberty to migrate it to Godot 4. I didn't test everything, but the main functionality is there.

aaaaaaaaargh commented 2 years ago

Haha, that's funny, I was about to address the same issue here :)

Looks like your work is very similar to what I've just done, so I'm commenting on that if you don't mind.

viniciusgerevini commented 2 years ago

Thanks @floriandotorg . That's great. As this is not backwards compatible, and Godot 4 is still in alpha, would you mind opening this PR against a version 4 branch. I will keep the main branch compatible with version 3 until 4 becomes stable.

Overall it's looking great. I need to download version 4 to helping you test it, though. :)

viniciusgerevini commented 2 years ago

I created a godot4 branch. I don't think you are able to change the base branch in the PR, so you might have to open a new one.

floriandotorg commented 2 years ago

Hey @viniciusgerevini, I'm so sorry, I overlooked your comment, just changed the base branch, hope it's still helpful :-)