search

viniciusgerevini / godot-aseprite-wizard

Godot Editor plugin to help import Aseprite animations to AnimationPlayers, AnimatedSprites and SpriteFrames.
MIT License
893 stars 43 forks source link

Config file lives outside version control #56

Closed TheOrioli closed 2 years ago

TheOrioli commented 2 years ago

The config file is currently stored in the user:// folder, which means that it cannot be version controlled. This becomes an issue when using the AsepriteWizard in cloud builds in case of any setting changes that need to be persisted.

For example, if the game requires the Aseprite Importer, the exported build will fail "successfully" because it simply will not perform an import of the .aseprite files. This will then cause a silent crash of the exported build on startup.

My suggestion is to move the settings from the user:// folder into the godot project settings and the editor settings.

The only setting that is machine specific among all the ones I see here is the Aseprite Command Path, all the other ones are project specific. image

This would work in a similar way to the import preset storage in #55

viniciusgerevini commented 2 years ago

That's a good point. Yeah, this config started with the Aseprite Command Path only, that's why it's outside the Project Settings. At first, I was considering all these configs as global, but now thinking again you are right, they are actually project specific.

I think we should be able to move all configs, but the Aseprite Command Path, to the Project Settings. The Command Path will become kind of an outlier, but that's ok.

As a bonus, the whole config will be gratefully simplified, which is great.

viniciusgerevini commented 2 years ago

I started working on this one and I just realised what you meant by EditorSettings. I can keep the Aseprite Command Path there and I wouldn't need a config dialog anymore. The only downside is that I would lose the test button, but I'm checking what can be done about it.