search

viniciusgerevini / godot-aseprite-wizard

Godot Editor plugin to help import Aseprite animations to AnimationPlayers, AnimatedSprites and SpriteFrames.
MIT License
893 stars 43 forks source link

Use ProjectSettings to make local and abs paths #75

Closed jthacker closed 1 year ago

jthacker commented 1 year ago

Use the standardized functions ProjectSettings.globalize_path and ProjectSettings.localize_path to get absolute and local paths respectively. This has the side effect of using an absolute file path when passing arguments to aseprite which seems to work around an issue in v1.3-beta21 with not handling relative paths on the CLI.

viniciusgerevini commented 1 year ago

Thanks for sending this fix. I'll run some tests before merging it, but it looks promising already.

jthacker commented 1 year ago

@viniciusgerevini Just following up to see if you had any feedback on the change.

viniciusgerevini commented 1 year ago

Hello @jthacker . Thanks for the nudge. This looks good. I wasn´t able to test with the automatic importer because unfortunately the version your branch is based on had a bug, but I think it's safe to merge it as is and I'll do further test afterwards.

Thank you very much for this fix.

viniciusgerevini commented 1 year ago

Confirming automatic importer works good on master. I'll port it to Godot 4 later