viniciusgerevini / godot-clyde-dialogue

Clyde Dialogue Language Importer and interpreter for Godot.
MIT License
89 stars 11 forks source link

fix: extends from Reference instead of Node to prevent memory leaks #2

Closed viniciusgerevini closed 3 years ago

viniciusgerevini commented 3 years ago

As pointed out on issue #1, extending from Node in scripts that are not attached to a scene tree may cause memory leaks, as those nodes are required to be freed explicitly. I'm changing all scripts to extend from Reference instead, which are freed as soon there are no more references to the object.

See https://docs.godotengine.org/en/stable/getting_started/workflow/best_practices/node_alternatives.html