viniciusgerevini / godot-clyde-dialogue

Clyde Dialogue Language Importer and interpreter for Godot.
MIT License
89 stars 11 forks source link

fixed broken importer #23

Closed RogerRandomDev closed 11 months ago

RogerRandomDev commented 1 year ago

the importer was missing a few lines for the godot 4.0 1.0.1 release, so i added them in

viniciusgerevini commented 1 year ago

Hello @RogerRandomDev . Thanks for looking into this. What is exactly the error you are seeing?

I'm asking because _get_priority() is an optional override and the default value is 1.0, which is virtually the same being set here. The plugin seems to be working as is on the current stable.

peachey2k2 commented 1 year ago

This is weird.

You can look at my issue if you want to but it's basically that the importer was broken for me without _get_priority. As @viniciusgerevini says, it already has a default value, or at least that's what the docs say. image Adding the function fixed the issue for me. I don't know why this works, but it does.

Wierdox commented 1 year ago

I had the same problem and solution as @peachey2k2 did. Thought I was going crazy, since I never used Clyde before so I thought I somehow screwed it up despite doing nothing. I'm using Godot 4.0.3 on Win10, if that helps at all. Since at least 2 of us have had this issue, I highly recommend merging this basic fix.

RogerRandomDev commented 1 year ago

The issue is that the engine seems to default it to 1.0 most of the time, but on my and a few other systems, it defaulted to 0.0. it works for me on most systems, just not my primary one without the line

Calandiel commented 11 months ago

Any chance for this to get merged in? ^-^

viniciusgerevini commented 11 months ago

Oh! Thanks for the ping and for confirming this issue. This went under my radar. I'll merge it and sent it to the asset lib soon.