ClydeDialogueResourceLoader parse error with load virtual function on Godot 3.6

[Riordan-DC]

Hi,

Love this plugin! Amazing work. It's small, maintainable, self contained. Perfect.

I've noticed that in the ClydeDialogueResourceLoaderyou will receive a parse error if using Godot 3.6 because the loadvirtual function requires an additional parameter.

Currently:

func load(path, original_path):
    return ResourceLoader.load(path)

To fix:

func load(path, original_path, use_sub_res_cache):
    return ResourceLoader.load(path)

You can see they have changed it in the docs: https://docs.godotengine.org/en/3.5/classes/class_resourceformatloader.html

https://docs.godotengine.org/en/3.6/classes/class_resourceformatloader.html

Not sure if it will still override the virtual function in 3.5 if the parameter is added.

[viniciusgerevini]

Thanks @Riordan-DC . Yeah, the override needs to match the parent signature, so I guess this will be a breaking change in 3.6. I'll keep this noted till the release candidate. Cheers