Closed verillious closed 2 years ago
Wow. This looks great. Spot on.
Yes, these tests are enough. All the other edge cases (i.e dialogue lines with contractions I'm, I've, don't) are already covered by the main interpreter tests.
Thanks for taking the time to code this. I'll be merging this today and releasing as a new major version .
I implemented your logic on the online editor. It works like a charm. You can test it here https://viniciusgerevini.github.io/clyde/
While implementing it I found a scenario not tested, two different leading quotes, like "'this"
. Your code is working good. I'll just include this in your already existing scenario after merging. Thanks again for the contribution. :)
No worries - thank you for making dialogue unbelievably simple in Godot! <3
test_lexer
- may need more elsewhere?closes #6