add ability to use single-quote strings

viniciusgerevini / godot-clyde-dialogue

Clyde Dialogue Language Importer and interpreter for Godot.

MIT License

89 stars 11 forks source link

add ability to use single-quote strings #8

Closed verillious closed 2 years ago

verillious commented 2 years ago

you can now use both single and double quote characters
they work together ( "a 'quote'.", 'character says "quote" angrily') etc.
adds tests for mixed-quote strings in test_lexer - may need more elsewhere?

closes #6

viniciusgerevini commented 2 years ago

Wow. This looks great. Spot on.

Yes, these tests are enough. All the other edge cases (i.e dialogue lines with contractions I'm, I've, don't) are already covered by the main interpreter tests.

Thanks for taking the time to code this. I'll be merging this today and releasing as a new major version .

viniciusgerevini commented 2 years ago

I implemented your logic on the online editor. It works like a charm. You can test it here https://viniciusgerevini.github.io/clyde/

While implementing it I found a scenario not tested, two different leading quotes, like "'this". Your code is working good. I'll just include this in your already existing scenario after merging. Thanks again for the contribution. :)

verillious commented 2 years ago

No worries - thank you for making dialogue unbelievably simple in Godot! <3