search

viniciusgf2 / Ambience

Your music in minecraft
Other
15 stars 12 forks source link

[BUG] - Client crash and unregistered area #29

Closed wolfkidsounds closed 3 years ago

wolfkidsounds commented 4 years ago

Describe the bug When marking an area, the soundnicer tool sometimes does not register correctly and you get the "area name" selection screen twice, after that, the client crashes.

Where playing in SinglePlayer or Multiplayer? -Multiplayer

To Reproduce Steps to reproduce the behavior:

  1. create areaname and select sound in config
  2. go in multiplayer
  3. select large area (100x10 blocks or something)
  4. right click again inside the selection to get the sound selection box (area naming selection)
  5. click confirm.
  6. right click again and the same dialog appears
  7. click confirm -> game crashes

Expected behavior After clicking on "confirm" the selected area is registered and the other UI (where you can select if you want to see the borders and such) appears.

Screenshots none

Mods used or modpack (please complete the following information): modlist.txt

**Mod Version used: Ambience-1.12.2-1.6.1

*Please send the followings files to help track the issue: ambience.properties.txt actual file is not in .txt only for uploading on github \crash-reports\crash-(last date)-server* only client crashes crash-2020-09-24_01.00.06-client.txt

Additional context I also had this issue with smaller areas. Maybe it takes a little for registering and I am too fast?

Keep it up! <3

wolfkidsounds commented 4 years ago

ADD:

After login, all is fine, the area is registered and works flawlessly...

viniciusgf2 commented 4 years ago

when you create a area do you imediately right click again to reopen the window? because it takes a few seconds for the server effectly register the area, as when you create the area it creates a schedule task on the server to it create when finishes the currently running tasks

wolfkidsounds commented 4 years ago

I don't immediately right click but on large areas (like this) it probably took around 15-20 seconds. Maybe one could add a timer or something that prevents right clicking during that period? (for example "please wait while the area is being registered")? :)

viniciusgf2 commented 4 years ago

it's takes time to create the areas but not that time 15-20, it takes like 1-3 seconds or less it's depends on the server TPS, I could not reproduce this error in my game

viniciusgf2 commented 3 years ago

I'm closing as I couldn't reproduce it and this probably is a very sporadic bug to occur