search

viniciusgf2 / Ambience

Your music in minecraft
Other
15 stars 12 forks source link

Ticking entity ambience crash #35

Closed Eckszy closed 4 years ago

Eckszy commented 4 years ago

Got a random crash on a ticking entity that looks like its tied to the ambience extras mod.

crash report 10-4-20.txt

this was on ambience extras 1.7.0 and forge 2854 1.12.2, multiplayer.

The crash report is from my wife's client, and it looks like the error is something ticking on me, Eckszy, when we were both on our multiplayer server. I have not experienced this crash on my end yet. It was raining in-game during the crash.

Eckszy commented 4 years ago

crash-2020-10-04_15.05.10-client.txt

experienced the crash again, this time my own client crashed and the ticking entity was again me.

Eckszy commented 4 years ago

crash-2020-10-04_17.44.42-client.txt crash report 2.txt

More crash reports of the same issue. Looks like ambience is crashing the game when an entity (in this cause either me or the other player on my server) has a ticking state on them. Consistently happened when entering biomes-o-plenty poison, and the crash persisted when the poison effect remained. The crash does not happen once the effect is gone.

I also experienced the crash when falling through Pixelmon's falling blocks- which also causes a tick trigger on the player.

Eckszy commented 4 years ago

Also- just realized NO music from ambience extras is working after this update. I will investigate the issue.

Eckszy commented 4 years ago

Ok, I may have solved it:

After updating my server AND my client to 1.7.0, the following paragraph was added to the ambience.properties file on the client's end: "

Enables or disables the notification in the chat that has updates(default=false)

ShowUpdateNotifications=false " HOWEVER, after doing some investigating, I found that this paragraph was not automatically added to the ambience.properties file on the server's end. I believe this resulted in the file not being read properly on the server, so no music showed up with the soundnizer tool, no music would play in previously set up regions, and the game would crash when attempting to play an 'attacked' event (probably because it was not being able to fallback on the 'generic' event).

Adding this paragraph server-side fixed everything. I tested things that had previously consistently crashed the game before and the crashes did not occur. I'm not certain why a mistake server-side caused a crash purely client side and never effected the server, but it could just be because the ambience.properties files not being in sync.