viniciusgf2 / Ambience

Your music in minecraft
Other
15 stars 12 forks source link

[BUG] Dimension and biome specific events do not work in 1.16 #74

Open ZilverLazarus opened 3 years ago

ZilverLazarus commented 3 years ago

Describe the bug Dimension and biome specific events do not work in 1.16 (more specifically, 1.16.4). Their event priority is completely skipped.

Are you playing in Singleplayer or Multiplayer? Singleplayer

To Reproduce Steps to reproduce the behavior:

[BIOMES] 1). Go to .minecraft -> ambience_music -> ambience.properties.

2). Comment all music events using biome dictionary primary / secondary tags. Example; "#primarytag.nether=nether", "#secondarytag.mesa=MesaBiomeTheme"

3). Comment the 'event.generic' music event. Example; "#event.generic=field"

4). Save ambience.properties.

5). Launch Minecraft with the new changes and load into a world (that has cheats enabled), or use the Reload Ambience keybind if the game is already running and in a loaded world (that has cheats enabled).

6). Use /locatebiome to go to any of the specific biomes listed in ambience.properties. Example; "/locatebiome minecraft:sunflower_plains"

7). Despite "biome.Sunflower+Plains=field" not being commented and having the highest priority, no music plays.

[DIMENSIONS] 8). In ambience.properties, one line above "dimension.-11325=silent", enter the following line; "dimension.-1=nether"

9). Save ambience.properties.

10). Reload by using the Reload Ambience keybind, or by re-launching Minecraft and loading back into the world. (I used both methods while testing.)

11). Enter the Nether.

12). Despite "dimension.-1=nether" being included in ambience.properties and having the highest priority, no music plays.

Expected behavior Any dimension/biome specific music events are supposed to trigger when entering a certain dimension/biome when properly listed in ambience.properties.

Screenshots Not applicable unless you require further evidence.

Mods used or modpack (please complete the following information): Ambience - Extras (Music Mod) [1.16.4] (Ambience-1.16.4-1.0.1.jar)

Mod Version used: Ambience-1.16.4-1.0.1

Please send the followings files to help track the issue: -..\ambience_music\ambience.properties -..\logs\latest.log -..\crash-reports\crash-(last date)-server -..\crash-reports\crash-(last date)-client The available, required files are listed below; ambience.log latest.log

Crash logs are also not available because the profile being used is new, and the bug doesn't crash the game. Additionally, GitHub doesn't support ".properties" as a valid file type, so I converted ambience.properties into a ".log". Make sure to convert ambience.log back into a ".properties" after you receive it.

Additional context While testing, I used Forge 36.1.9 on a new profile with fresh install of the mod and your personal music pack. Nothing in the music pack has been changed. I also had no other mods installed to ensure a conflict with other mods was not possible.

The steps to recreate the bug have been done for your as far as ambience.properties goes. Just switch out your files with mine to test.