search

viniciussalvati / react-app-rewire-sass

Adds SASS to your react-app-rewired
MIT License
1 stars 0 forks source link

Version supporting webpack2 not available on npmjs #1

Open callebstrom opened 6 years ago

callebstrom commented 6 years ago

Hi!

Just started using react-app-rewire and tried using react-app-rewire-sass to solve some of the issues in my SASS transpile chain (seems like this is the perfect module for the job).

I downloaded the latest version from npmjs (version 1.2.3) however, that version does not seem to support webpack2's rules configuration as I am getting the following error:

(...)node_modules/react-app-rewire-sass/index.js:8
config.module.loaders.find(urlLoader).exclude.push(/\.scss$/);

It seems like you are supporting webpack2 based on the current master of index.js, but that does not seem to be published to npmjs.

Would it be possible for you to publish this or are there any outstanding issues that needs to be resolved first?

Thanks!

Best regards, Calle

viniciussalvati commented 6 years ago

@callebstrom I started developing this to be used at work, as we migrate from Angular to React, but I did not test it for production builds yet, or has a extensive test during development. I just pushed it to github so I don't lose the code.

You can try to add it with the git URL, (that's how I'm doing it for now, anyway)

Btw, the version available in npmjs is not mine. I think it's linked in react-app-rewire's repository, but it didn't work for me. So, I can't upload my own version with the same name. (I'm open to name suggestions)