vinifmor / bauh

Graphical user interface for managing your Linux applications. Supports AppImage, Debian and Arch packages (including AUR), Flatpak, Snap and native Web applications
zlib License
995 stars 69 forks source link

Install AppImage File Generates a Blank .desktop File #186

Closed lfom closed 3 years ago

lfom commented 3 years ago

Before opening a new issue Install the staging branch and check if the unexpected behavior is happening there as well. If you are on ArchLinux-based distro, you can install it through AUR (bauh-staging). Otherwise, you have to clone the repository and install it with pip.

Done, the problem persists

Describe the bug

  1. Download latest version of Avidemux from https://www.fosshub.com/Avidemux.html
  2. Rename downloaded file extension to .AppImage (see #185)
  3. Use bauh to install the AppImage file
  4. There is no icon for the installed app and bauh cannot run it either
  5. The newly created .desktop file in ~/.local/share/applications is empty (0 bytes)
$ update-desktop-database ~/.local/share/applications
Could not parse file "/home/lfom/.local/share/applications/bauh_appimage_avidemux.desktop": Key file does not have group ?Desktop Entry?

Related errors from running bauh in the terminal:

/bin/sh: 1: Syntax error: word unexpected (expecting ")")

Software Environment bauh version: 0.9.18 O.S: _Pop!OS 21.04 (like Ubuntu 21.04) Python version: Pyhton 3.9.5 Installation method: pip

Once again, thanks a lot for bauh. Regards

vinifmor commented 3 years ago

@lfom thanks for reporting this. I will have a look.

vinifmor commented 3 years ago

Actually it is not a bug. Bauh just copies the desktop file provided by the AppImage (this application provides an empty one). Bauh coud generate a fresh one for this sort of scenarios. I'm going to add this as an enhancement task.

vinifmor commented 3 years ago

I've published the fix/enhancement to the staging branch. Try reinstalling the file and check if the desktop entry is properly generated.

lfom commented 3 years ago

@vinifmor .desktop file is not empty anymore, and it launches the app correctly. I only missed the "Comment=" line.

vinifmor commented 3 years ago

@lfom the missing "Comment" field is expected, since the current installation form does not have it. It would fit as a separate feature.

lfom commented 3 years ago

@vinifmor Isn't it the Description when installing manually?

vinifmor commented 3 years ago

You're right. I forgot that for .desktop files the "Comment" field is equivalent to "Description". I'm going to add it. Thanks.

vinifmor commented 3 years ago

Already on staging

lfom commented 3 years ago

Tested on 0.9.19 and it seems to be working fine. Thank you!