search

vinissimus / async-asgi-testclient

A framework-agnostic library for testing ASGI web applications
MIT License
159 stars 20 forks source link

Fix return type annotation of the methods invoking TestClient.open() #26

Closed otsuka closed 4 years ago

otsuka commented 4 years ago

TestClient.open() method return Response instance, but the return type annotation of the methods(like get() or post()) in which invoking open() is bytes.

I modified these type annotations.

codecov-io commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           6        6           
  Lines         378      378           
=======================================
  Hits          324      324           
  Misses         54       54
Impacted Files Coverage Δ
async_asgi_testclient/testing.py 87.89% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e9434c...fc54b1f. Read the comment docs.

masipcat commented 4 years ago

Thank you!

I'll release a new version after doing https://github.com/vinissimus/async-asgi-testclient/issues/25