vinitkumar / json2xml

json to xml converter in python3
https://json2xml.readthedocs.io/
Other
98 stars 32 forks source link

fix: ci issue due to mypy update on python3.11 #166

Closed vinitkumar closed 1 year ago

vinitkumar commented 1 year ago
json2xml/dicttoxml.py:250: error: Function "Type[Number]" could always be 
true in boolean context  [truthy-function]

Latest mypy identifies this as problematic, so cleaning this up condition.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.02% // Head: 94.02% // No change to project coverage :thumbsup:

Coverage data is based on head (e691e58) compared to base (63aa3b3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ======================================= Coverage 94.02% 94.02% ======================================= Files 6 6 Lines 536 536 ======================================= Hits 504 504 Misses 32 32 ``` | [Impacted Files](https://codecov.io/gh/vinitkumar/json2xml/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vinit+Kumar) | Coverage Δ | | |---|---|---| | [json2xml/dicttoxml.py](https://codecov.io/gh/vinitkumar/json2xml/pull/166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vinit+Kumar#diff-anNvbjJ4bWwvZGljdHRveG1sLnB5) | `89.14% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vinit+Kumar). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vinit+Kumar)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.