Closed Jeroendevr closed 1 year ago
Base: 94.04% // Head: 94.24% // Increases project coverage by +0.20%
:tada:
Coverage data is based on head (
dd6c49b
) compared to base (2ca3076
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This looks good. This fix is in line with the discussion we had in the twitter thread, right?
I don't have twitter, I think you meant PR #165 or issue #163? That's correct! this is THE FIX π
I don't have twitter, I think you meant PR #165 or issue #163? That's correct! this is THE FIX π
I am sorry I did a typo. I meant the GitHub issue thread. Furthermore, I will review the code a bit deeply and if all is good, will merge and cut a release.
Yes that's great. I'll await your feedback and do some refactoring afterwards.
For the dicttoxml module did not have a direct test where
attr_type=True
it was only indirectly tested using json2xml. So hereby a small increase of tests.Forgot to branch properly so hereby also my solution to #165 Although I have some Ideas to make the code cleaner and perhaps another test or two I would like your opinon.