codepathreview
commented
9 years ago @vinitpatwa Hi Vinit,
:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:
- Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here. Pay close attention to Error Handling section.
- You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
- Your custom Movie cell should have a property called
movie. In the custom setter ofmovie, you should configure the various labels and images. This decouples your custom cells from the table view controllers. - Nice work loading the images asynchronously.
- Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- Nice work implementing the error message on network failure.
Instead of the video link. You should create a gif file and embed it into your README file. One website you can use is imgur. Use their Upload Images tool to create a gif from your video. Once you have your gif, you can embed it just like you embed an image to the README file. Here is a link to master Github Markdown tricks. For your gif file: Click on "Examples" then the "Images" tab.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
My App is complete /cc @codepathreview