Error in scanner.py for python-3.8 (JWOC)

[Vinamrata1086]

scanner.py

• https://github.com/vinitshahdeo/PortScanner/blob/306d91d5dac999c3b1fa531584854d787b2fec1e/src/single/scanner.py#L33

The low and high range is not mentioned which is low=1 and high=8888

• This line of code is giving an error. with open("config.json") as json_file: https://github.com/vinitshahdeo/PortScanner/blob/306d91d5dac999c3b1fa531584854d787b2fec1e/src/single/scanner.py#L12

[welcome[bot]]

Thanks for opening your first issue! Mentors will get back to you soon. Meanwhile check this repo for more.

[vinitshahdeo]

@Kashish121 Can you please verify the above and work with @Vinamrata1086 for the changes, if required.

[Kashish121]

@Vinamrata1086 That's probably due to change in the directory structure of the code. Try moving config.json to the same folder as scanner.py.

[Vinamrata1086]

@Vinamrata1086 That's probably due to change in the directory structure of the code. Try moving config.json to the same folder as scanner.py.

ya it worked

so can I change the directory of config and create pr?

[Kashish121]

Hey @Vinamrata1086 , this is the standard organized directory structure followed in the project. Instead of changing the directory structure, try adding config.json actual path to the code. Wouldn't it be smarter? ;)

You can refer to feature\python2 or master branch for the same.

You may create a PR for this. 👍🏽

[Vinamrata1086]

I have added the path.