syntax error in python files

vinitshahdeo / PortScanner

A go-to tool for scanning network. Scan all the open ports for a given host with just one click.

https://vinitshahdeo.github.io/PortScanner/

MIT License

126 stars 113 forks source link

syntax error in python files #128

Closed iamsonukushwaha closed 4 months ago

iamsonukushwaha commented 3 years ago

Describe the bug there are syntax errors in all the python files of src/ directory

Screenshots

welcome[bot] commented 3 years ago

Thanks for opening your first issue! Mentors will get back to you soon. Meanwhile check this repo for more.

nitish-awasthi commented 3 years ago

@flyingsonu122 The print statement syntax is valid for python 2.7 for python 3.x check out feature/python 3.8 branch.

iamsonukushwaha commented 3 years ago

we need to

@flyingsonu122 The print statement syntax is valid for python 2.7 for python 3.x check out feature/python 3.8 branch.

we should migrate default branch to python3.8+

iamsonukushwaha commented 3 years ago

@vinitshahdeo everyone (who are working first time on this project) is having problem with this default branch supporting for python 2.7

we should migrate default branch to python3.8+

nitish-awasthi commented 3 years ago

@Kashish121 Please look into this!

iamsonukushwaha commented 3 years ago

@vinitshahdeo @ishika1727 please have a look

Kashish121 commented 3 years ago

@flyingsonu122 @nitish-awasthi we'll be switching from python2.x to python3.x for the master branch pretty soon.

I believe @ranaaditya is working on the same. @ranaaditya, please let me know the status?

ranaaditya commented 3 years ago

@flyingsonu122 @nitish-awasthi we'll be switching from python2.x to python3.x for the master branch pretty soon.

I believe @ranaaditya is working on the same. @ranaaditya, please let me know the status?

Yeah, I am working on it, soon it will be merged in master.

iamsonukushwaha commented 3 years ago

@flyingsonu122 @nitish-awasthi we'll be switching from python2.x to python3.x for the master branch pretty soon.

I believe @ranaaditya is working on the same. @ranaaditya, please let me know the status?

Yeah, I am working on it, soon it will be merged in master.

@ranaaditya you can see my PR #132 which fixes this and other issues as well

guptachitresh commented 3 years ago

@Kashish121 I want to work on this issue. Can you please assign me this?

Kashish121 commented 3 years ago

@guptachitresh ye please go ahead. I have assigned you this issue. 👍🏽

Kashish121 commented 3 years ago

Reopened.