avinashkranjan commented 4 years ago

Description

fixes issue 57 updating code from python2.7 to python3

Fixes #57

Type of change

Added ip scanner

[❌ ] Bug fix (non-breaking change which fixes an issue)
[✔ ] New feature (non-breaking change which adds functionality)
[❌ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

[✔ ] My code follows the style guidelines of this project
[ ✔] I have performed a self-review of my own code
[✔ ] I have commented my code, particularly in hard-to-understand areas
[❌ ] I have made corresponding changes to the documentation
[✔ ] My changes generate no new warnings
[✔ ] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules
[x] I have added all the three reviewers: @vinitshahdeo, @kashish121 & @ishika1727

avinashkranjan commented 4 years ago

@vinitshahdeo @Kashish121 @ishika1727 Please review the changes

avinashkranjan commented 4 years ago

@vinitshahdeo Resolved..Hav a look.

avinashkranjan commented 4 years ago

@Kashish121 @ishika1727 If you guys could have a look too..

avinashkranjan commented 4 years ago

Left comments.

What? I didn't get that..

avinashkranjan commented 4 years ago

@vinitshahdeo Any Updates

avinashkranjan commented 4 years ago

@vinitshahdeo any updates?

avinashkranjan commented 4 years ago

@vinitshahdeo When will it get merged