vinitshahdeo / PortScanner

A go-to tool for scanning network. Scan all the open ports for a given host with just one click.
https://vinitshahdeo.github.io/PortScanner/
MIT License
133 stars 114 forks source link

Timer Clock Adjusted by making some minor changes #86

Open Amulya-coder opened 4 years ago

Amulya-coder commented 4 years ago

Fixes #61

By Changing the font-size property present in index.css file of id selector seconds, minutes and colon.

Amulya-coder commented 4 years ago

@ishika1727 Alright I have started working on the latest frontend (feature/frontend) branch and clone it but when I run the port Scanner via Powershell it will still shows the previous website then in the website I entered the localhost,range and started scanning the ports but it's not showing the timer I attached the screenshot of both Powershell and website after scanning then you can please tell me where I was getting wrong.I tested multiple times by entering host and ranges the powershell was showing the results website also changes below scan button you can see the changes it shows the host and range below it scanning completion time everything is working fine so why timer is not appearing on the right.

TimerSize

Amulya-coder commented 4 years ago

TimerSize2

Amulya-coder commented 4 years ago

@ishika1727 Now it's working and showing the timer

Amulya-coder commented 4 years ago

@ishika1727 Is this size of the timer is Fine

AdjustTimer

ishika1727 commented 4 years ago

@ishika1727 Is this size of the timer is Fine

AdjustTimer

Can you increase it a little bit. Its too small

vinitshahdeo commented 4 years ago

@Amulya-coder Can we have padding in teal colored div? There should spacing between box and the numbers viz time.

Amulya-coder commented 4 years ago

@ishika1727 @Kashish121 The required changes are made . Please review it

image

Kashish121 commented 4 years ago

@Amulya-coder it seems you created the branch from master. Use feature/frontend branch to make changes in your code and re-create the PR in frontend/feature.

I appreciate your efforts. The changes are as per the requirement 💯 . You just need to branch off from the right branch. :)

Amulya-coder commented 4 years ago

@vinitshahdeo @Kashish121 Changes have been made to feature/frontend can you please verify it. I apologize for the delay was kinda busy in these days.