vinitshahdeo / inspirational-quotes

:bulb: A simple NPM Package which returns random Inspirational Quotes. Get your daily quote and stay motivated! :v: :cherry_blossom:
https://www.npmjs.com/package/inspirational-quotes
MIT License
331 stars 1.81k forks source link

Duplicate quote #850

Open tdlm opened 4 years ago

tdlm commented 4 years ago

The following two quotes are contained in the data.json:

  {  
      "text":"A ship in harbor is safe. But that’s now what ships are built for.",
      "from":"William Shedd"
   }
   {  
      "text":"A ship in harbor is safe, but that’s not what ships are for.",
      "from":"John Shedd"
   },

According to quoteinvestigator, the second one is correct, and the first one is wrong. Plus it contains a typo!

welcome[bot] commented 4 years ago

Thanks for opening this issue! 🤗 Wishing you a great Hacktoberfest 2020 🙌 🎉 ⚡️ Are you looking for beginner-friendly issues? Check out this repo.

Hacktoberfest2020

📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to DEV article. Retweet this.

Open Source Love

Check out few other repos below 🚀

PortScanner SimpleBio HBD Map Of India

Show some ❤️

Say Hi on Twitter! 👋

Twitter Follow

tdlm commented 4 years ago

@vinitshahdeo I was going to start creating some pull requests, but it looks like you're pretty busy.

Are there any other people on the repo who can pull changes in? There are a lot of pull requests that look good to bring into the project (in my opinion). 😎

Looks like you could use some assistance?

rjworks commented 3 years ago

I agree