vinitshahdeo / peerlist-readme-badge

Markdown badge generator for any Peerlist profile 💚 | Style your GitHub Profile README with a Peerlist badge to showcase your work | Try out here: https://peerlist.io/tools/readme-badge
https://vinitshahdeo.github.io/peerlist-readme-badge/
MIT License
60 stars 25 forks source link

Feat: option to attach peerlist profile link #17

Closed ramdhanihendrie closed 1 year ago

ramdhanihendrie commented 1 year ago

This PR is for issue #16

welcome[bot] commented 1 year ago

Thanks for opening this pull request! 🤗 Wishing you a great Hacktoberfest 2020 🙌 🎉 ⚡️ Are you looking for more beginner-friendly issues? Check out this repo.

Open Source Love

Check out few other repos below 🚀

PortScanner SimpleBio HBD Map Of India

Show some ❤️

Say Hi on Twitter! 👋

Twitter Follow

PS: Please add @vinitshahdeo as a reviewer if you haven't added.

netlify[bot] commented 1 year ago

Deploy Preview for peerlist-readme-badge ready!

Name Link
Latest commit 058ec7886a6dd60e24a2fd80a0fc99a9349db6f9
Latest deploy log https://app.netlify.com/sites/peerlist-readme-badge/deploys/633c0f662dd67c000849573f
Deploy Preview https://deploy-preview-17--peerlist-readme-badge.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vinitshahdeo commented 1 year ago

Tracking the above issue here: #18

ramdhanihendrie commented 1 year ago

@vinitshahdeo I think it's not a bug that comes from this feature. The deployed branch has the same issue.

While you change the style, you have to re-generate it to update the badge with the selected style

vinitshahdeo commented 1 year ago

@ramdhanihendrie Yes - tracking the issue separately #18. This is out of the scope of this PR. Great job 👏

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🙌🎉⚡️ Show some love by starring a few of my repositories.

ramdhanihendrie commented 1 year ago

@vinitshahdeo Would you like to add a hacktoberfest-accepted label to this PR? Thanks

vinitshahdeo commented 1 year ago

Sure - @ramdhanihendrie added the label. Please check if you could open some beginner-friendly issues for this project. I just want to open some first-timers issues so that beginners can kickstart their open-source journey.