search

vinkla / extended-acf

Register advanced custom fields with object-oriented PHP
MIT License
445 stars 61 forks source link

Tab field: Conditional Logic #70

Closed zangab closed 4 years ago

zangab commented 4 years ago

Expected Behavior

I tried to add a conditional logic to the Tab field as this is possible via ACF but the corresponding trait is not used on the Tab field. I should be able to add a conditional logic to a Tab field with the ->conditionalLogic([...]) function call.

Actual Behavior

The function call results in a Fatal Error: Uncaught Error: Call to undefined method WordPlate\Acf\Fields\Tab::conditionalLogic() ...

Steps to Reproduce the Problem

1. Import Tab field
2. Create Tab field
3. Try adding conditional logic

Versions

vinkla commented 4 years ago

Thanks for pointing it out @zangab! Would you mind sending us a pull request adding this feature. We probably only need to import the trait on the Tab class.

zangab commented 4 years ago

@vinkla created the PR

vinkla commented 4 years ago

Fixed in #71