Version 5.0 - Githubissues

vinkla / hashids

A small PHP library to generate YouTube-like ids from numbers. Use it when you don't want to expose your database ids to the user.

https://hashids.org/php

MIT License

5.26k stars 417 forks source link

Version 5.0 #181

Closed vinkla closed 1 year ago

vinkla commented 2 years ago

This pull request is work in progress on the next major version of the package. I would say the package is feature complete and we should probably only add syntactic sugar such as type hints. I think we should probably stop supporting PHP 7 at some point. This PR is currently a playground for whatever idea comes to mind. Since this package is used by a lot of developers I want to hear what the community have to say. What can we improve?

ludo237 commented 2 years ago

Type hinting and php 7 drop are welcome addictions for a major version

machour commented 2 years ago

Same here, this new version is really welcome.

I would advise adding a compatibility table in the README file to help people quickly decide what version they should be using.

vinkla commented 2 years ago

These are the current changes in this pull request:

Added property type declarations
Removed HashidsException class
Removed PHP 7 and 8.0 support
Renamed Bc class to BCMath

I was thinking about adding type hints to the math interface but bcmath and gmp behaves differently.