Fix the data provider to test both Gmp and BCMath when both extensions are installed

vinkla / hashids

A small PHP library to generate YouTube-like ids from numbers. Use it when you don't want to expose your database ids to the user.

https://hashids.org/php

MIT License

5.29k stars 417 forks source link

Closed stof closed 1 year ago

stof commented 1 year ago

Tests should run for both implementations when possible.

vinkla commented 1 year ago

Thanks for the pull request Christophe!

What are the benefits of having both available? We run the test suite twice with each math extension.

stof commented 1 year ago

@vinkla this allows having all tests running when running tests locally for instance (and it would also help if you try to compute code coverage)

vinkla commented 1 year ago

Thanks Christophe 🙌