search

vinkla / wordplate

A boilerplate for WordPress, built with Composer and designed with sensible defaults.
2.12k stars 155 forks source link

laravel mix issue on compile #207

Closed lgt closed 6 years ago

lgt commented 6 years ago

Hi,

first of all thank you for this package. Having started to use I face an issue on assets compile with laravel-mix. The js is getting compiled without errors. The scrip is quite simple

import $ from 'jquery'

console.log($)

alert('test again')

As the js is getting loaded there is a console error

Uncaught SyntaxError: Invalid or unexpected token

If I copy paste the html from DOM and I let it run the error will not occur.

Any idea what can be behind?

vinkla commented 6 years ago

I'm glad you like WordPlate. Don't know what your issue might be. The error message doesn't say much. I suggest you open a new issue in the laravel-mix repository.

lgt commented 6 years ago

to repeat my self If I copy paste the html from DOM and I let it run and the error will not occur.. Is not a laravel-mix issue this lays on wordplate

screen shot 2018-07-11 at 19 07 06

and here is what I'm talking about the working static html copy pasted from DOM

screen shot 2018-07-11 at 19 04 52
vinkla commented 6 years ago

Is not a laravel-mix issue this lays on wordplate.

If you don't know what the error is, how can you be sure that it has something to do with WordPlate? Laravel Mix lays on top of WordPlate. The CSS and JavaScript is compiled with Laravel Mix.

lgt commented 6 years ago

See my screenshots! It seems to be some encoding issue on comments what is not right handled by wordpress basic theme

vinkla commented 6 years ago

Again, Laravel Mix lays on top of WordPlate. I suggest you open an issue in the Laravel Mix repository. They might be able to help you.

For future issues anywhere on GitHub I urge you to try being more humble and polite as possible. It is the way to go if you want help from maintainers and collaborators building open-source software for free on the web.

lgt commented 6 years ago

Sorry for the input but first of all you did not let this issue to stand for an hour to be analysed by other followers (if I take a look on your issues status everything is closed) and I must say I'm using laravel daily and I have some experience around with laravel-mix which is a really cool project by the way provided by Jeffrey Way. So for now I will let this project maybe will improve by time

vinkla commented 6 years ago

We don't have time for this. I'm locking this issue.

https://mikemcquaid.com/2018/03/19/open-source-maintainers-owe-you-nothing/