search

vinniejames / coinfox

Crypto Coin Portfolio Manager - Track all of your Bitcoin and crypto coin investments
http://coinfox.co
GNU General Public License v3.0
64 stars 21 forks source link

Price notifications #28

Open vinniejames opened 7 years ago

vinniejames commented 7 years ago

Add price hi/low notifications

vinniejames commented 6 years ago

@williamluke4 I'm most interested in getting this one going. Adding browser notifications / push alerts for pricing

williamluke4 commented 6 years ago

@vinniejames Will have look in to service workers

vinniejames commented 6 years ago

Yes, exactly, @williamluke4 ! Would you be interested in doing a bit of research here and/or submitting a PR?

Ideally, I'd like users to be able to select an upper/lower bound to receive an alert, eg Ethereum price: ping when price drops below $500 or above $1500

williamluke4 commented 6 years ago

Yeah shouldn't be too hard!

williamluke4 commented 6 years ago

@vinniejames Well I was wrong! This would require a backend server to send push notification to the app.

vinniejames commented 6 years ago

Setting up a server wouldn't be out of the question. I wonder if it could be accomplished instead using something like this: https://blog.cloudflare.com/cloudflare-workers-unleashed/amp/

williamluke4 commented 6 years ago

@vinniejames Yeah that would work! Just quickly setup serviceworker push notification in a separate branch!

williamluke4 commented 6 years ago

Though we could use periodicSync to check the market but its still in development and wouldn't give live notifications

vinniejames commented 6 years ago

Nice, let me know if you make some progress implementing the serviceWorker! I can move it over to a server environment if need be once a PR is ready.

Looks like periodicSync wont work on Safari, so if you want to try that route please make sure there is a fallback for Safari users