Upgrade/power up pokemon

vinnymac / PokeNurse

💉 A tool for Pokémon Go to aid in transferring and evolving Pokémon

284 stars 48 forks source link

Upgrade/power up pokemon #130

Open SamuelMoraesF opened 8 years ago

vinnymac commented 8 years ago

@SamuelMoraesF thanks for the PR 👍

If you could fix the remaining lint issues I can merge this in. I think we might need a dropdown now instead of buttons since it is getting crowded, @mackhankins what do you think?

SamuelMoraesF commented 8 years ago

Dropdown or a button group?

IMHO, a button group should be better :)

vinnymac commented 8 years ago

We will have 4 buttons with this PR. Even if you used glyphs with the button group it would quickly take up too much real estate as we add more. Need a solution that will work as we add more actions.

mackhankins commented 8 years ago

Also need to fix the lint errors. Most editors have some type of eslint plugin

SamuelMoraesF commented 8 years ago

How about a complete redesign? screenshot from 2016-08-26 09-53-12

I've made some modifications:

Grid instead of a table
Active status for "Toggle Caught Species" button
Hide action buttons(transfer, evolve and upgrade) by default, and show when a Pokémon is selected with slide up effect

If you are ok with these modifications, I can do more things and open a new PR for the new layout/design.

SamuelMoraesF commented 8 years ago

And sorry, I've forgotten about lint. I'll fix ASAP

mackhankins commented 8 years ago

You should checkout the navbar branch to see what we're slowly working on there also.

vinnymac commented 8 years ago

@SamuelMoraesF yea I like the design, but hold off on that. Maybe we can discuss it after v1.4 is out. We already have some UI changes coming, and so I don't want to waste anyones time with that. I like the idea of the grid, especially how responsive that can be.

You should join us on discord and we can discuss more ;)